[INFO] cloning repository https://github.com/tylerreisinger/sprite-atlas
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tylerreisinger/sprite-atlas" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftylerreisinger%2Fsprite-atlas", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftylerreisinger%2Fsprite-atlas'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 0cd33afe97009c1c5513fa89ec40c272db96ed1f
[INFO] checking tylerreisinger/sprite-atlas against try#b946edaa85de45f124065f52b1bc55ba2fb4f9fb for pr-157562
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftylerreisinger%2Fsprite-atlas" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/tylerreisinger/sprite-atlas
[INFO] finished tweaking git repo https://github.com/tylerreisinger/sprite-atlas
[INFO] tweaked toml for git repo https://github.com/tylerreisinger/sprite-atlas written to /workspace/builds/worker-7-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/tylerreisinger/sprite-atlas on toolchain b946edaa85de45f124065f52b1bc55ba2fb4f9fb
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b946edaa85de45f124065f52b1bc55ba2fb4f9fb" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/tylerreisinger/sprite-atlas already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+b946edaa85de45f124065f52b1bc55ba2fb4f9fb" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64
[INFO] running `Command { std: "docker" "start" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64" "/opt/rustwide/cargo-home/bin/cargo" "+b946edaa85de45f124065f52b1bc55ba2fb4f9fb" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64" "/opt/rustwide/cargo-home/bin/cargo" "+b946edaa85de45f124065f52b1bc55ba2fb4f9fb" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.54
[INFO] [stderr]    Compiling byteorder v1.3.1
[INFO] [stderr]    Compiling proc-macro2 v0.4.29
[INFO] [stderr]    Compiling rayon-core v1.4.1
[INFO] [stderr]    Compiling num-integer v0.1.39
[INFO] [stderr]    Compiling syn v0.15.34
[INFO] [stderr]     Checking crossbeam-utils v0.2.2
[INFO] [stderr]    Compiling rayon v1.0.3
[INFO] [stderr]     Checking adler32 v1.0.3
[INFO] [stderr]    Compiling num-derive v0.2.5
[INFO] [stderr]    Compiling num-rational v0.2.1
[INFO] [stderr]     Checking either v1.5.2
[INFO] [stderr]    Compiling serde v1.0.91
[INFO] [stderr]     Checking gif v0.10.1
[INFO] [stderr]     Checking inflate v0.4.5
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking deflate v0.7.19
[INFO] [stderr]     Checking num_cpus v1.10.0
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking rand_os v0.1.3
[INFO] [stderr]     Checking clap v2.33.0
[INFO] [stderr]     Checking rand v0.6.5
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking num-iter v0.1.37
[INFO] [stderr]     Checking png v0.14.1
[INFO] [stderr]    Compiling quote v0.6.12
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking tiff v0.2.2
[INFO] [stderr]     Checking image v0.21.1
[INFO] [stderr]     Checking texture_atlas v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:36:14
[INFO] [stdout]    |
[INFO] [stdout] 36 |     for x in (region.left..region.left+region.width) {
[INFO] [stdout]    |              ^                                     ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 36 -     for x in (region.left..region.left+region.width) {
[INFO] [stdout] 36 +     for x in region.left..region.left+region.width  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:40:14
[INFO] [stdout]    |
[INFO] [stdout] 40 |     for y in (region.top..region.top+region.height) {
[INFO] [stdout]    |              ^                                    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 40 -     for y in (region.top..region.top+region.height) {
[INFO] [stdout] 40 +     for y in region.top..region.top+region.height  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:47:14
[INFO] [stdout]    |
[INFO] [stdout] 47 |     for y in (region.top..region.top+region.height) {
[INFO] [stdout]    |              ^                                    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 47 -     for y in (region.top..region.top+region.height) {
[INFO] [stdout] 47 +     for y in region.top..region.top+region.height  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:48:18
[INFO] [stdout]    |
[INFO] [stdout] 48 |         for x in (region.left..region.left+region.width) {
[INFO] [stdout]    |                  ^                                     ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 48 -         for x in (region.left..region.left+region.width) {
[INFO] [stdout] 48 +         for x in region.left..region.left+region.width  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:36:14
[INFO] [stdout]    |
[INFO] [stdout] 36 |     for x in (region.left..region.left+region.width) {
[INFO] [stdout]    |              ^                                     ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 36 -     for x in (region.left..region.left+region.width) {
[INFO] [stdout] 36 +     for x in region.left..region.left+region.width  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:40:14
[INFO] [stdout]    |
[INFO] [stdout] 40 |     for y in (region.top..region.top+region.height) {
[INFO] [stdout]    |              ^                                    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 40 -     for y in (region.top..region.top+region.height) {
[INFO] [stdout] 40 +     for y in region.top..region.top+region.height  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:47:14
[INFO] [stdout]    |
[INFO] [stdout] 47 |     for y in (region.top..region.top+region.height) {
[INFO] [stdout]    |              ^                                    ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 47 -     for y in (region.top..region.top+region.height) {
[INFO] [stdout] 47 +     for y in region.top..region.top+region.height  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around `for` iterator expression
[INFO] [stdout]   --> src/render.rs:48:18
[INFO] [stdout]    |
[INFO] [stdout] 48 |         for x in (region.left..region.left+region.width) {
[INFO] [stdout]    |                  ^                                     ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 48 -         for x in (region.left..region.left+region.width) {
[INFO] [stdout] 48 +         for x in region.left..region.left+region.width  {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `root`
[INFO] [stdout]    --> src/spatial_tree.rs:144:21
[INFO] [stdout]     |
[INFO] [stdout] 144 |         if let Some(root) = self.root.as_mut() {
[INFO] [stdout]     |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_root`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `f`
[INFO] [stdout]    --> src/spatial_tree.rs:309:19
[INFO] [stdout]     |
[INFO] [stdout] 309 |     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
[INFO] [stdout]     |                   ^ help: if this is intentional, prefix it with an underscore: `_f`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `v`
[INFO] [stdout]   --> src/render.rs:69:21
[INFO] [stdout]    |
[INFO] [stdout] 69 |         if let Some(v) = &node.value {
[INFO] [stdout]    |                     ^ help: if this is intentional, prefix it with an underscore: `_v`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:46:35
[INFO] [stdout]    |
[INFO] [stdout] 46 |     values.sort_unstable_by_key(|(i, w, h)| u32::MAX - w.max(h));
[INFO] [stdout]    |                                   ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:58:35
[INFO] [stdout]    |
[INFO] [stdout] 58 |     values.sort_unstable_by_key(|(i, w, h)| u32::MAX - w*h/*w.max(h)*/);
[INFO] [stdout]    |                                   ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `generate_random_test_data` is never used
[INFO] [stdout]   --> src/main.rs:39:4
[INFO] [stdout]    |
[INFO] [stdout] 39 | fn generate_random_test_data(n: u32) -> Vec<(u32, u32, u32)> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `generate_discrete_test_data` is never used
[INFO] [stdout]   --> src/main.rs:51:4
[INFO] [stdout]    |
[INFO] [stdout] 51 | fn generate_discrete_test_data(n: u32, choices: &[u32]) -> Vec<(u32, u32, u32)> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]    --> src/spatial_tree.rs:317:45
[INFO] [stdout]     |
[INFO] [stdout] 317 |     fn new(tree: &'a mut SpatialTree<T>) -> SpatialTreeNodeIterMut<T> {
[INFO] [stdout]     |                   --                        ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                   |
[INFO] [stdout]     |                   the lifetime is named here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'a`
[INFO] [stdout]     |
[INFO] [stdout] 317 |     fn new(tree: &'a mut SpatialTree<T>) -> SpatialTreeNodeIterMut<'a, T> {
[INFO] [stdout]     |                                                                    +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `root`
[INFO] [stdout]    --> src/spatial_tree.rs:144:21
[INFO] [stdout]     |
[INFO] [stdout] 144 |         if let Some(root) = self.root.as_mut() {
[INFO] [stdout]     |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_root`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `f`
[INFO] [stdout]    --> src/spatial_tree.rs:309:19
[INFO] [stdout]     |
[INFO] [stdout] 309 |     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
[INFO] [stdout]     |                   ^ help: if this is intentional, prefix it with an underscore: `_f`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `v`
[INFO] [stdout]   --> src/render.rs:69:21
[INFO] [stdout]    |
[INFO] [stdout] 69 |         if let Some(v) = &node.value {
[INFO] [stdout]    |                     ^ help: if this is intentional, prefix it with an underscore: `_v`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:46:35
[INFO] [stdout]    |
[INFO] [stdout] 46 |     values.sort_unstable_by_key(|(i, w, h)| u32::MAX - w.max(h));
[INFO] [stdout]    |                                   ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `i`
[INFO] [stdout]   --> src/main.rs:58:35
[INFO] [stdout]    |
[INFO] [stdout] 58 |     values.sort_unstable_by_key(|(i, w, h)| u32::MAX - w*h/*w.max(h)*/);
[INFO] [stdout]    |                                   ^ help: if this is intentional, prefix it with an underscore: `_i`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `generate_random_test_data` is never used
[INFO] [stdout]   --> src/main.rs:39:4
[INFO] [stdout]    |
[INFO] [stdout] 39 | fn generate_random_test_data(n: u32) -> Vec<(u32, u32, u32)> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `generate_discrete_test_data` is never used
[INFO] [stdout]   --> src/main.rs:51:4
[INFO] [stdout]    |
[INFO] [stdout] 51 | fn generate_discrete_test_data(n: u32, choices: &[u32]) -> Vec<(u32, u32, u32)> {
[INFO] [stdout]    |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]    --> src/spatial_tree.rs:317:45
[INFO] [stdout]     |
[INFO] [stdout] 317 |     fn new(tree: &'a mut SpatialTree<T>) -> SpatialTreeNodeIterMut<T> {
[INFO] [stdout]     |                   --                        ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                   |
[INFO] [stdout]     |                   the lifetime is named here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'a`
[INFO] [stdout]     |
[INFO] [stdout] 317 |     fn new(tree: &'a mut SpatialTree<T>) -> SpatialTreeNodeIterMut<'a, T> {
[INFO] [stdout]     |                                                                    +++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.30s
[INFO] running `Command { std: "docker" "inspect" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64", kill_on_drop: false }`
[INFO] [stdout] 9fb4ef193359d5f2b88e2a52dc47e07962c266630f265dad26723c8e8ceb7b64
